Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSDK-7468: add captureAll method #494

Merged
merged 3 commits into from
May 9, 2024
Merged

RSDK-7468: add captureAll method #494

merged 3 commits into from
May 9, 2024

Conversation

Rob1in
Copy link
Member

@Rob1in Rob1in commented May 9, 2024

No description provided.

@Rob1in Rob1in added ready-for-protos add this when you want protos to compile on every commit and removed ready-for-protos add this when you want protos to compile on every commit labels May 9, 2024
@Rob1in Rob1in requested review from njooma and bhaney May 9, 2024 15:53
njooma
njooma reviewed May 9, 2024
View reviewed changes
proto/viam/service/vision/v1/vision.proto
repeated Detection detections = 2;
repeated Classification classifications = 3;
repeated common.v1.PointCloudObject objects = 4;
google.protobuf.Struct extra = 99;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think extra needs to be included in the response?

Copy link
Member

@bhaney bhaney May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually in the scope for the message to also have extra in the response
https://docs.google.com/document/d/119ITK_p0xKyYBTlyksYUEjsHm_lAx3b4c9CaJNtdOnI/edit#heading=h.tcicyojyqi6c

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool!

@Rob1in Rob1in added the ready-for-protos add this when you want protos to compile on every commit label May 9, 2024
@njooma njooma self-requested a review May 9, 2024 16:47
@Rob1in Rob1in added ready-for-protos add this when you want protos to compile on every commit and removed ready-for-protos add this when you want protos to compile on every commit labels May 9, 2024
@github-actions github-actions bot added the safe to test committer is a member of this org label May 9, 2024
@Rob1in Rob1in added ready-for-protos add this when you want protos to compile on every commit and removed ready-for-protos add this when you want protos to compile on every commit labels May 9, 2024
@Rob1in Rob1in merged commit a2b2989 into viamrobotics:main May 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@bhaney bhaney bhaney approved these changes

Assignees
No one assigned
Labels
ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rob1in @njooma @bhaney